Any comments would be appreciated. Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected. Signed-off-by: Nishanth Aravamudan Signed-off-by: Maximilian Attems Signed-off-by: Domen Puncer --- kj-domen/drivers/net/e1000/e1000_ethtool.c | 4 +--- 1 files changed, 1 insertion(+), 3 deletions(-) diff -puN drivers/net/e1000/e1000_ethtool.c~msleep_interruptible-drivers_net_e1000_e1000_ethtool drivers/net/e1000/e1000_ethtool.c --- kj/drivers/net/e1000/e1000_ethtool.c~msleep_interruptible-drivers_net_e1000_e1000_ethtool 2004-12-25 01:34:57.000000000 +0100 +++ kj-domen/drivers/net/e1000/e1000_ethtool.c 2004-12-25 01:34:57.000000000 +0100 @@ -1554,9 +1554,7 @@ e1000_phys_id(struct net_device *netdev, e1000_setup_led(&adapter->hw); mod_timer(&adapter->blink_timer, jiffies); - set_current_state(TASK_INTERRUPTIBLE); - - schedule_timeout(data * HZ); + msleep_interruptible(data * 1000); del_timer_sync(&adapter->blink_timer); e1000_led_off(&adapter->hw); clear_bit(E1000_LED_ON, &adapter->led_status); _